Conversation
This would help us to easily manoeuvre through the list of actions in the UI. category: refactor ticket: none
Improved nodes counts validation for reshare DKG. category: refactor ticket: none
Added threshold validation for `RunDKG` and `RunReshareDKG`. Previous behavior delegated the check down the stack to allow underlying library (kyber) to validate the threshold. Given that Kyber has weak validation that can lead to weird late errors, it is more convenient to verify the threshold upfront. Additionally added verification such that users cannot remove all nodes with "remove operators" command. category: refactor ticket: none
Added dkg p2p wire message size validation. category: refactor ticket: none
Verify that the actual sender's peer ID matches the claimed peer index in nodesigs. category: refactor ticket: none
Using `io.LimitReader` in `FetchDefinition`, the maximum allowed definition size is 16Mb. category: refactor ticket: none
Improving frostp2p code quality. category: refactor ticket: none
This fixes a bug in `restoreKey` routine that affects "remove operators" edit command. category: bug ticket: none
Improves `reshare.go` checks: 1. ` restoreCommits` out-of-bounds checks for `shareNum` 2. polynomial commitment validation during reshare (against expected validator pubkey) category: refactor ticket: none
Better nonce generation and variation for dkg. category: refactor ticket: none
|
pinebit
approved these changes
Feb 10, 2026
KaloyanTanev
added
the
merge when ready
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main-v1.9 #4313 +/- ##
=============================================
+ Coverage 56.56% 56.59% +0.03%
=============================================
Files 237 237
Lines 31471 31559 +88
=============================================
+ Hits 17800 17861 +61
- Misses 11390 11412 +22
- Partials 2281 2286 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add DKG changes in v1.9.0-rc2
category: misc
ticket: none